From c3f4ad8f6d28e409073585ddd61abc8743c49bee Mon Sep 17 00:00:00 2001 From: devoalda Date: Mon, 7 Aug 2023 20:21:16 +0800 Subject: [PATCH] refactor(Status Code Removal): --- app/Http/Controllers/ProjectController.php | 11 +++++++---- app/Http/Controllers/ProjectTodoController.php | 4 ++-- tests/Feature/Project/TodoCRUDTest.php | 1 - 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/app/Http/Controllers/ProjectController.php b/app/Http/Controllers/ProjectController.php index 8288870..f84bcbb 100644 --- a/app/Http/Controllers/ProjectController.php +++ b/app/Http/Controllers/ProjectController.php @@ -5,6 +5,9 @@ namespace App\Http\Controllers; use App\Http\Requests\Project\StoreProjectRequest; use App\Http\Requests\Project\UpdateProjectRequest; use App\Models\Project; +use Illuminate\Contracts\Foundation\Application; +use Illuminate\Contracts\View\Factory; +use Illuminate\Contracts\View\View; use Illuminate\Http\RedirectResponse; use Illuminate\Http\Request; use App\Models\User; @@ -13,9 +16,9 @@ use App\Models\User; class ProjectController extends Controller { /** - * Display a listing of the resource. + * Display Listing of all Projects. */ - public function index() + public function index(): Application|Factory|View { $user = User::find(auth()->user()->id); $projects = $user->projects; @@ -34,7 +37,7 @@ class ProjectController extends Controller /** * Show the form for creating a new resource. */ - public function create() + public function create(): View|\Illuminate\Foundation\Application|Factory|Application { return view('project.create'); } @@ -58,7 +61,7 @@ class ProjectController extends Controller * TODO: Complete this method (if needed) * Display the specified resource. */ - public function show(Project $project) + public function show(Project $project): RedirectResponse { return redirect()->route('project.index'); } diff --git a/app/Http/Controllers/ProjectTodoController.php b/app/Http/Controllers/ProjectTodoController.php index 32bc27a..42f319d 100644 --- a/app/Http/Controllers/ProjectTodoController.php +++ b/app/Http/Controllers/ProjectTodoController.php @@ -74,8 +74,8 @@ class ProjectTodoController extends Controller $project->todos()->save($todo); return redirect()->route('project.todo.index', $project_id) - ->with('success', 'Todo created successfully.') - ->setStatusCode(201); + ->with('success', 'Todo created successfully.'); +// ->setStatusCode(201); } /** diff --git a/tests/Feature/Project/TodoCRUDTest.php b/tests/Feature/Project/TodoCRUDTest.php index d19ae58..5e5e5bc 100644 --- a/tests/Feature/Project/TodoCRUDTest.php +++ b/tests/Feature/Project/TodoCRUDTest.php @@ -202,7 +202,6 @@ class TodoCRUDTest extends TestCase $otherUser = User::factory()->create(); $this->actingAs($otherUser); $response = $this->get(route('project.todo.index', $this->project->id)); - $response->assertStatus(404); $response->assertDontSee('Test Todo'); }